Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for other AWS partitions (cn, us-gov, etc.) #42

Merged
merged 3 commits into from
Apr 10, 2024
Merged

feat: Add support for other AWS partitions (cn, us-gov, etc.) #42

merged 3 commits into from
Apr 10, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Apr 10, 2024

Describe your changes

Adding support for other AWS partitions, such as aws-cn and aws-us-gov.

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger self-assigned this Apr 10, 2024
@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review April 10, 2024 20:35
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LeonLuttenberger LeonLuttenberger merged commit 8e8baa8 into awslabs:main Apr 10, 2024
10 checks passed
@LeonLuttenberger LeonLuttenberger deleted the feat/partition-support branch April 10, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants