Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add ray orchestrator module #253

Merged
merged 16 commits into from
Oct 23, 2024
Merged

feat: add ray orchestrator module #253

merged 16 commits into from
Oct 23, 2024

Conversation

kukushking
Copy link
Contributor

@kukushking kukushking commented Oct 21, 2024 •
edited
Loading

Describe your changes

  • added ray orchestrator module with a Step Function to orchestrate submission of Ray jobs via Kubernetes BatchJob
  • added RBAC/identity mapping
  • added test cases
  • add sample training-6B.py script via Kubernetes ConfigMap
  • update manifests
  • update docs

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kukushking kukushking self-assigned this Oct 21, 2024
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 9fdf03b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 487f40c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 3e3a375
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 9edd9b3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: ca0804b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 7573e8c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking requested a review from a team October 21, 2024 20:58
@kukushking kukushking marked this pull request as ready for review October 22, 2024 10:56
@kukushking kukushking requested a review from dgraeber October 22, 2024 14:47
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: dbff0cb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

clokep
clokep previously approved these changes Oct 22, 2024
View reviewed changes
modules/eks/ray-orchestrator/README.md Outdated Show resolved Hide resolved
modules/eks/ray-orchestrator/README.md Outdated Show resolved Hide resolved
modules/eks/ray-orchestrator/modulestack.yaml Outdated Show resolved Hide resolved
modules/eks/ray-orchestrator/ray_orchestrator_stack.py Show resolved Hide resolved
modules/eks/ray-orchestrator/README.md Outdated Show resolved Hide resolved
@kukushking @clokep
proofreading
1445fab 
Co-authored-by: Patrick Cloke <[email protected]>
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 1445fab
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: bb44186
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@kukushking kukushking merged commit 0240463 into awslabs:main Oct 23, 2024
4 checks passed
@kukushking kukushking deleted the feat/ray-orchestrator-sfn branch October 23, 2024 14:12
@kukushking kukushking added this to the 1.7.0 milestone Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgraeber dgraeber dgraeber approved these changes

@clokep clokep clokep approved these changes

Assignees

@kukushking kukushking

Labels
None yet
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
4 participants
@kukushking @malachi-constant @clokep @dgraeber