Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit bucket name length in templates #224

Merged
merged 8 commits into from
Aug 19, 2024

Conversation

EthanBunce
Copy link
Collaborator

@EthanBunce EthanBunce commented Aug 16, 2024

Describe your changes

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@EthanBunce EthanBunce changed the title Fix/limit deployment name length Limit bucket name length in templates Aug 16, 2024
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: a07fcde
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@EthanBunce EthanBunce merged commit 4f3e788 into awslabs:main Aug 19, 2024
3 checks passed
@EthanBunce EthanBunce deleted the fix/limitDeploymentNameLength branch August 19, 2024 11:50
mahesh-balumuri pushed a commit to mahesh-balumuri/mlops-modules that referenced this pull request Aug 25, 2024
* Limit name length in model deploy template

* Updated readme

* Removed sagemaker project ID from bucket names

* Increase timeout on finetune template

* Reduced bucket name length for batch inference module

* Updating changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants