Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add accelerate as extra for transformers library #221

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

EthanBunce
Copy link
Collaborator

Describe your changes

Added accelerate as extra for transformers in finetune llm template

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: d96f5f3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@@ -1,4 +1,4 @@
transformers==4.38.0
transformers[accelerate]==4.38.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To cross-link, I removed this in #206 as I was mistaken that it was unused. From conversations with @EthanBunce we realized that transformers uses it automatically if is installed. Adding it back as an extra will hopefully make it clear that we don't use it directly, but still want it installed.

@EthanBunce EthanBunce merged commit a6dbdae into awslabs:main Aug 14, 2024
3 checks passed
@EthanBunce EthanBunce deleted the fix/addAccelerate branch August 14, 2024 15:10
mahesh-balumuri pushed a commit to mahesh-balumuri/mlops-modules that referenced this pull request Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants