Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update module checks workflow #203

Merged
merged 6 commits into from
Jul 23, 2024

Conversation

malachi-constant
Copy link
Contributor

@malachi-constant malachi-constant commented Jul 23, 2024

Describe your changes

  • updated get-modules workflow to only run tests against changed files in modules/**
  • adds workflow specific to changes for requirements-dev.txt so all static checks are run

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant malachi-constant self-assigned this Jul 23, 2024
@malachi-constant malachi-constant marked this pull request as draft July 23, 2024 15:35
@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: e511460
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 44c3bc1
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 52fad3e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: dc8ccc5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 8dc3005
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant malachi-constant marked this pull request as ready for review July 23, 2024 15:55
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If requirements-dev.txt changes, I think we should run the workflow on all modules. For example, if we update ruff or mypy, I think we want to make sure all the modules are well formatter.

Other than that, great job! I think it's a good change

@malachi-constant
Copy link
Contributor Author

If requirements-dev.txt changes, I think we should run the workflow on all modules. For example, if we update ruff or mypy, I think we want to make sure all the modules are well formatter.

Other than that, great job! I think it's a good change

Ahh yes good call @LeonLuttenberger will add some conditional stuff in there.

@malachi-constant
Copy link
Contributor Author

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: 2c4e5fc
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@malachi-constant
Copy link
Contributor Author

If requirements-dev.txt changes, I think we should run the workflow on all modules. For example, if we update ruff or mypy, I think we want to make sure all the modules are well formatter.
Other than that, great job! I think it's a good change

Ahh yes good call @LeonLuttenberger will add some conditional stuff in there.

@LeonLuttenberger cleanest way I could see was just to have another similar workflow only targeted to requirements-dev.txt

Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, that's really helpful!

@LeonLuttenberger LeonLuttenberger merged commit 8bbd6c9 into main Jul 23, 2024
3 checks passed
@LeonLuttenberger LeonLuttenberger deleted the workflow/discriminate-module-checks branch July 23, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants