-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update module checks workflow #203
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If requirements-dev.txt
changes, I think we should run the workflow on all modules. For example, if we update ruff
or mypy
, I think we want to make sure all the modules are well formatter.
Other than that, great job! I think it's a good change
Ahh yes good call @LeonLuttenberger will add some conditional stuff in there. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
@LeonLuttenberger cleanest way I could see was just to have another similar workflow only targeted to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, that's really helpful!
Describe your changes
get-modules
workflow to only run tests against changed files inmodules/**
requirements-dev.txt
so all static checks are runChecklist before requesting a review
CHANGELOG.MD
with a description of my changesscripts/validate.sh
)seedfarmer apply
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.