Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move Python formatting and linting checks to ruff #19

Merged
merged 16 commits into from
Mar 7, 2024
Merged

chore: Move Python formatting and linting checks to ruff #19

merged 16 commits into from
Mar 7, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented Feb 28, 2024

Describe your changes

Move Python formatting and linting checks to ruff.

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review February 28, 2024 18:22
@kukushking
Copy link
Contributor

@LeonLuttenberger @malachi-constant Please hold merging this PR, we have a couple modules actively worked on that need to go before we change the formatting scripts. Ideally I'd like this to be merged when it's the only PR open against the repo so we don't impact others work.

@LeonLuttenberger LeonLuttenberger marked this pull request as draft February 28, 2024 19:41
@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review March 7, 2024 15:18
kukushking
kukushking previously approved these changes Mar 7, 2024
@LeonLuttenberger LeonLuttenberger merged commit 1d3f733 into awslabs:main Mar 7, 2024
9 checks passed
@LeonLuttenberger LeonLuttenberger deleted the chore/ruff branch March 7, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants