feat: Add SageMaker JumpStart Foundation Model Endpoint module
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
Signed-off-by: Anton Kukushkin <[email protected]>
There was a problem hiding this comment.
This module isn't getting picked up by our module checking workflow for two reasons:
- The workflow locates modules based on the presence of a
testsdirectory. We should probably change this so that it tries to find adeployspec.yamlfile, since that's the commonality between all modules - The workflow assumes that all modules are written in Python. I'm not sure how best to solve this, but I don't think we should merge this until we at least have our validation script and unit test process running.
Edit: I began adding support for Typescript in PR #15
Signed-off-by: Anton Kukushkin <[email protected]>
|
Yeah @LeonLuttenberger, I know, the focus of this PR is on the module itself. I like [1] - deployspec is the reliable way to find a module. I wouldn't consider [2] blocking, but def agree we should add typescript validation. Thanks for taking this one on in #15 |
Signed-off-by: Anton Kukushkin <[email protected]>
LeonLuttenberger
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.