Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a module for data quality monitoring of a SageMaker Endpoint. #117

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

clokep
Copy link
Collaborator

@clokep clokep commented Jun 11, 2024

Describe your changes

Adds a new module (sagemaker-model-monitoring-module) for monitoring data quality of a SageMaker Endpoint.

Take a look at the added README on how to test this. Unfortunately the out-of-the-box SageMaker Pipelines cannot be used as they don't have the proper steps to output the required data for monitoring.

Issue ticket number and link

N/A

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant

This comment was marked as outdated.

@clokep clokep force-pushed the data-quality-monitoring branch from 30e511c to 9cb6da3 Compare June 11, 2024 12:45
@malachi-constant

This comment was marked as outdated.

@clokep clokep force-pushed the data-quality-monitoring branch from 9cb6da3 to 1506ad2 Compare June 11, 2024 12:57
@malachi-constant

This comment was marked as outdated.

@clokep clokep force-pushed the data-quality-monitoring branch from 1506ad2 to 2bd0ae7 Compare June 11, 2024 13:15
@malachi-constant

This comment was marked as outdated.

@clokep clokep marked this pull request as ready for review June 12, 2024 15:52
@malachi-constant

This comment was marked as outdated.

@clokep clokep requested a review from kukushking June 12, 2024 17:07
kukushking
kukushking previously approved these changes Jun 13, 2024
Copy link
Contributor

@kukushking kukushking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

Copy link
Contributor

@LeonLuttenberger LeonLuttenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! I left a couple of minor nitpicky comments.

@clokep clokep dismissed stale reviews from LeonLuttenberger and kukushking via d30c230 June 13, 2024 17:12
@malachi-constant
Copy link
Contributor

AWS CodeBuild CI Report

  • CodeBuild project: AIOpsModuleTestsInfrastruct-doMLXEYsnmxr
  • Commit ID: d30c230
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@LeonLuttenberger LeonLuttenberger merged commit 7eef525 into awslabs:main Jun 13, 2024
19 checks passed
@clokep clokep deleted the data-quality-monitoring branch June 13, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants