-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a module for data quality monitoring of a SageMaker Endpoint. #117
Add a module for data quality monitoring of a SageMaker Endpoint. #117
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
30e511c
to
9cb6da3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
9cb6da3
to
1506ad2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
1506ad2
to
2bd0ae7
Compare
This comment was marked as outdated.
This comment was marked as outdated.
modules/sagemaker/sagemaker-model-monitoring/requirements-dev.in
Outdated
Show resolved
Hide resolved
modules/sagemaker/sagemaker-model-monitoring/sagemaker_model_monitoring/settings.py
Show resolved
Hide resolved
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! I left a couple of minor nitpicky comments.
modules/sagemaker/sagemaker-model-monitoring/requirements-dev.in
Outdated
Show resolved
Hide resolved
modules/sagemaker/sagemaker-model-monitoring/sagemaker_model_monitoring/stack.py
Outdated
Show resolved
Hide resolved
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Describe your changes
Adds a new module (
sagemaker-model-monitoring-module
) for monitoring data quality of a SageMaker Endpoint.Take a look at the added README on how to test this. Unfortunately the out-of-the-box SageMaker Pipelines cannot be used as they don't have the proper steps to output the required data for monitoring.
Issue ticket number and link
N/A
Checklist before requesting a review
CHANGELOG.MD
with a description of my changesscripts/validate.sh
)seedfarmer apply
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.