Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Refactor sagemaker-templates to use pydantic for inputs #101

Merged
merged 5 commits into from
May 30, 2024
Merged

chore: Refactor sagemaker-templates to use pydantic for inputs #101

merged 5 commits into from
May 30, 2024

Conversation

LeonLuttenberger
Copy link
Contributor

@LeonLuttenberger LeonLuttenberger commented May 29, 2024

Describe your changes

Refactor sagemaker-templates to use pydantic for inputs

Checklist before requesting a review

  • I updated CHANGELOG.MD with a description of my changes
  • If the change was to a module, I ran the code validation script (scripts/validate.sh)
  • If the change was to a module, I have added thorough tests
  • If the change was to a module, I have added/updated the module's README.md
  • If a module was added, I added a reference to the module to the repository's README.md
  • I verified that my code deploys successfully using seedfarmer apply

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@malachi-constant

This comment was marked as outdated.

@LeonLuttenberger LeonLuttenberger marked this pull request as ready for review May 29, 2024 21:41
@kukushking kukushking merged commit 2063792 into awslabs:main May 30, 2024
16 checks passed
@LeonLuttenberger LeonLuttenberger deleted the refactor/pydantic-sagemaker-templates-sc branch May 30, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants