JavaScript (v3): Rekognition, DDB - Remove unhelpful examples #6817
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpyle0819
added
the
Task
github-actions
bot
added
the
Javascript-v3
cpyle0819
requested review from
a team,
Laren-AWS and
brmur
and removed request for
DennisTraub and
a team
brmur
approved these changes
Sep 6, 2024
Laren-AWS
approved these changes
Sep 6, 2024
The rekognition PPE app is not much different from the photo analyzer cross service example. The only difference is the action used analyze the photos. The example also used outdated jquery versions, and needed heavy refactoring. There are no usages of this app in a dev guide so I'm removing it.
The item tracker example was an express app showing basic usage of DynamoDB. It also had deprecated versions of jquery and needed heavy refactoring to be up to standard. Other examples cover the DynamoDB usage more thoroughly, and this example isn't being referenced anywhere.
While we don't have other examples of analyzing video, it's a simple call that's covered by SDK reference docs. This example is using deprecated versions of jquery, is documented incorrectly, needs heavy refactoring, and is showcasing bad practices by doing so much processing on the client side. Deleting this for now as I believe it's anti-helpful to customers.
DavidSouther
force-pushed
the
corepyle/jquery-update-V1365905289
branch
from
243ff6b to
0fa8d3c
Compare
DavidSouther
added
On Call Review complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the rekognition PPE, rekognition video analyzer, and item tracker examples.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.