Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JavaScript (v3): Libs - Add more common steps, allow for default values, and refactor. #6720

Merged
merged 1 commit into from
Aug 12, 2024
Merged

JavaScript (v3): Libs - Add more common steps, allow for default values, and refactor. #6720

merged 1 commit into from
Aug 12, 2024

Conversation

cpyle0819
Copy link
Contributor

@cpyle0819 cpyle0819 commented Aug 9, 2024 •
edited
Loading

  • add a 'default' value option to ScenarioInput. Providing a default value will display it to use in the prompt and use if the user continues without changing the value.
  • refactor ScenarioInput to be more readable

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@cpyle0819 cpyle0819 added the Task A general update to the code base for language clarification, missing actions, tests, etc. label Aug 9, 2024
@cpyle0819 cpyle0819 requested a review from a team August 9, 2024 15:21
@cpyle0819 cpyle0819 self-assigned this Aug 9, 2024
@cpyle0819 cpyle0819 requested review from scmacdon and removed request for a team August 9, 2024 15:21
@github-actions github-actions bot added the Javascript-v3 This issue relates to the AWS SDK for Javascript V3 label Aug 9, 2024
@cpyle0819 cpyle0819 requested a review from DavidSouther August 12, 2024 13:10
@cpyle0819 cpyle0819 added the On Call Review needed This work needs an on-call review label Aug 12, 2024
@DavidSouther DavidSouther added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Aug 12, 2024
@DavidSouther DavidSouther merged commit ffc84c8 into awsdocs:main Aug 12, 2024
19 checks passed
ford-at-aws pushed a commit that referenced this pull request Aug 13, 2024
@cpyle0819 @ford-at-aws
JavaScript (v3): Libs - Add more common steps, allow for default valu…
7912677 
…es, and refactor. (#6720)
shepazon pushed a commit to shepazon/aws-doc-sdk-examples that referenced this pull request Aug 23, 2024
@cpyle0819 @shepazon
JavaScript (v3): Libs - Add more common steps, allow for default valu…
958b238 
…es, and refactor. (awsdocs#6720)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scmacdon scmacdon scmacdon approved these changes

@DavidSouther DavidSouther Awaiting requested review from DavidSouther

Assignees

@cpyle0819 cpyle0819

Labels
Javascript-v3 This issue relates to the AWS SDK for Javascript V3 On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cpyle0819 @DavidSouther @scmacdon