Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Fixed an off-by-one bug in the mock questioner AskChoice #6572

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Go: Fixed an off-by-one bug in the mock questioner AskChoice #6572

merged 1 commit into from
Jun 21, 2024

Conversation

Laren-AWS
Copy link
Contributor

  • Mock questioner was returning the specified choice, but it should subtract one from it to match the real implementation.
  • Updated the FileSystem tests to close both references to the file to avoid a "file in use" error in Windows.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Laren-AWS Laren-AWS requested a review from beqqrry-aws June 20, 2024 22:10
@Laren-AWS Laren-AWS self-assigned this Jun 20, 2024
@github-actions github-actions bot added the Go-v2 This issue relates to the AWS SDK for Go V2 label Jun 20, 2024
@Laren-AWS Laren-AWS added the Bug An update to fix incorrect code or typos. label Jun 20, 2024
@Laren-AWS Laren-AWS force-pushed the bug/go-demo-tools-askchoice branch from 774c657 to 0dfb7e6 Compare June 20, 2024 22:18
@Laren-AWS Laren-AWS added the On Call Review complete On call review complete label Jun 21, 2024
@Laren-AWS Laren-AWS merged commit e26d2c3 into awsdocs:main Jun 21, 2024
15 of 17 checks passed
@Laren-AWS Laren-AWS deleted the bug/go-demo-tools-askchoice branch June 21, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beqqrry-aws beqqrry-aws beqqrry-aws approved these changes

Assignees

@Laren-AWS Laren-AWS

Labels
Bug An update to fix incorrect code or typos. Go-v2 This issue relates to the AWS SDK for Go V2 On Call Review complete On call review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Laren-AWS @beqqrry-aws