Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6558 c++s3 update to current standards #6569

Merged

Conversation

meyertst-aws
Copy link
Contributor

Updated the S3 examples to conform with codeing standards

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@meyertst-aws meyertst-aws added C++ This issue relates to the AWS SDK for C++ Task A general update to the code base for language clarification, missing actions, tests, etc. labels Jun 20, 2024
@meyertst-aws meyertst-aws requested a review from a team June 20, 2024 15:13
@meyertst-aws meyertst-aws self-assigned this Jun 20, 2024
@meyertst-aws meyertst-aws requested review from scmacdon and removed request for a team June 20, 2024 15:13
@meyertst-aws meyertst-aws force-pushed the 6558-c++s3-update-to-current-standards branch from c24400f to 05440db Compare June 20, 2024 15:13
@meyertst-aws meyertst-aws force-pushed the 6558-c++s3-update-to-current-standards branch from a07713e to 1436c4f Compare July 1, 2024 18:39
Copy link
Contributor

@scmacdon scmacdon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through each file and they look good.

@meyertst-aws meyertst-aws added the On Call Review needed This work needs an on-call review label Jul 2, 2024
@meyertst-aws meyertst-aws force-pushed the 6558-c++s3-update-to-current-standards branch 2 times, most recently from 28f23db to 9d969a8 Compare July 2, 2024 17:30
@meyertst-aws meyertst-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Jul 2, 2024
@meyertst-aws meyertst-aws force-pushed the 6558-c++s3-update-to-current-standards branch from 9d969a8 to 0e272f5 Compare July 3, 2024 13:50
@meyertst-aws meyertst-aws merged commit 5473d43 into awsdocs:main Jul 3, 2024
15 checks passed
@meyertst-aws meyertst-aws deleted the 6558-c++s3-update-to-current-standards branch July 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ This issue relates to the AWS SDK for C++ On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants