-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6558 c++s3 update to current standards #6569
Merged
meyertst-aws
merged 7 commits into
awsdocs:main
from
meyertst-aws:6558-c++s3-update-to-current-standards
Jul 3, 2024
Merged
6558 c++s3 update to current standards #6569
meyertst-aws
merged 7 commits into
awsdocs:main
from
meyertst-aws:6558-c++s3-update-to-current-standards
Jul 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyertst-aws
added
C++
This issue relates to the AWS SDK for C++
Task
A general update to the code base for language clarification, missing actions, tests, etc.
labels
Jun 20, 2024
meyertst-aws
force-pushed
the
6558-c++s3-update-to-current-standards
branch
from
June 20, 2024 15:13
c24400f
to
05440db
Compare
meyertst-aws
force-pushed
the
6558-c++s3-update-to-current-standards
branch
from
July 1, 2024 18:39
a07713e
to
1436c4f
Compare
scmacdon
reviewed
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went through each file and they look good.
meyertst-aws
force-pushed
the
6558-c++s3-update-to-current-standards
branch
2 times, most recently
from
July 2, 2024 17:30
28f23db
to
9d969a8
Compare
meyertst-aws
added
On Call Review complete
On call review complete
and removed
On Call Review needed
This work needs an on-call review
labels
Jul 2, 2024
scmacdon
approved these changes
Jul 2, 2024
meyertst-aws
force-pushed
the
6558-c++s3-update-to-current-standards
branch
from
July 3, 2024 13:50
9d969a8
to
0e272f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
C++
This issue relates to the AWS SDK for C++
On Call Review complete
On call review complete
Task
A general update to the code base for language clarification, missing actions, tests, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the S3 examples to conform with codeing standards
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.