Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: Writeme canonical titles #6382

Merged
merged 9 commits into from
Apr 30, 2024

Conversation

Laren-AWS
Copy link
Contributor

I broke this PR into two commits so it's a little easier to review:

Commit 1 has code changes: Fix some WRITEME issues and generate titles for Actions:

  • Open files with utf-8 encoding.
  • Case-insensitive README filename comparison.
  • Render titles for actions in READMEs.
  • Fixed WRITEME to check for combined language and version.
  • Fixed some metadata issues.

Commit 2: newly generated READMEs for all examples.

  • These should only update the names of the Actions in the lists.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added C++ This issue relates to the AWS SDK for C++ DotNet-v3 This issue relates to the AWS SDK for .NET V3 Go-v2 This issue relates to the AWS SDK for Go V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) Swift This issue relates to the AWS SDK for Swift CLI Relates to the AWS CLI Java-v2 This issue relates to the AWS SDK for Java V2 Tools This issue relates to a custom tooling to streamline development tasks SAP ABAP This issue relates to the AWS SDK for SAP ABAP labels Apr 26, 2024
@Laren-AWS Laren-AWS requested review from DavidSouther and removed request for ford-at-aws and rlhagerm April 26, 2024 23:55
@Laren-AWS Laren-AWS self-assigned this Apr 26, 2024
@Laren-AWS Laren-AWS added Task A general update to the code base for language clarification, missing actions, tests, etc. Tools This issue relates to a custom tooling to streamline development tasks and removed Tools This issue relates to a custom tooling to streamline development tasks labels Apr 26, 2024
.tools/readmes/config.py Show resolved Hide resolved
.tools/readmes/render.py Outdated Show resolved Hide resolved
.tools/readmes/scanner.py Show resolved Hide resolved
.tools/readmes/scanner.py Show resolved Hide resolved
@github-actions github-actions bot added the Go-v1 This issue relates to the AWS SDK for Go V1 label Apr 29, 2024
@Laren-AWS Laren-AWS force-pushed the writeme-canonical-titles branch from 399492d to 1ec522c Compare April 29, 2024 21:25
@Laren-AWS Laren-AWS added the On Call Review needed This work needs an on-call review label Apr 30, 2024
@beqqrry-aws beqqrry-aws added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Apr 30, 2024
@Laren-AWS Laren-AWS force-pushed the writeme-canonical-titles branch from 6fa942a to 65a3cb9 Compare April 30, 2024 18:51
@beqqrry-aws beqqrry-aws merged commit eac0be7 into awsdocs:main Apr 30, 2024
13 checks passed
@Laren-AWS Laren-AWS deleted the writeme-canonical-titles branch June 10, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ This issue relates to the AWS SDK for C++ CLI Relates to the AWS CLI DotNet-v3 This issue relates to the AWS SDK for .NET V3 Go-v1 This issue relates to the AWS SDK for Go V1 Go-v2 This issue relates to the AWS SDK for Go V2 Java-v2 This issue relates to the AWS SDK for Java V2 Javascript-v3 This issue relates to the AWS SDK for Javascript V3 Kotlin This issue relates to the AWS SDK for Kotlin On Call Review complete On call review complete PHP This issue relates to the AWS SDK for PHP Python This issue relates to the AWS SDK for Python (boto3) Ruby This issue relates to the AWS SDK for Ruby Rust This issue relates to the AWS SDK for Rust (Preview) SAP ABAP This issue relates to the AWS SDK for SAP ABAP Swift This issue relates to the AWS SDK for Swift Task A general update to the code base for language clarification, missing actions, tests, etc. Tools This issue relates to a custom tooling to streamline development tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants