Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rust: Remove setup tasks that are not needed with larger runners. #5712

Merged
merged 1 commit into from
Nov 28, 2023
Merged

Rust: Remove setup tasks that are not needed with larger runners. #5712

merged 1 commit into from
Nov 28, 2023

Conversation

DavidSouther
Copy link
Contributor

@DavidSouther DavidSouther commented Nov 27, 2023 •
edited
Loading

This clean up was necessary with the default runners, because they would run out of disk space downloading the Rust SDK dependencies. Two things have changed:

  1. We have moved to the crates.io 1.x releases, drastically reducing required dependency disk size
  2. We have switched to larger runners, which have larger disk available.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added Python This issue relates to the AWS SDK for Python (boto3) Rust This issue relates to the AWS SDK for Rust (Preview) Java-v2 This issue relates to the AWS SDK for Java V2 GitHub settings This affects GitHub settings labels Nov 27, 2023
@DavidSouther DavidSouther self-assigned this Nov 28, 2023
@DavidSouther DavidSouther force-pushed the rust/workers/better_setup branch from 8e2f1c7 to 654c180 Compare November 28, 2023 14:11
@github-actions github-actions bot removed Python This issue relates to the AWS SDK for Python (boto3) Rust This issue relates to the AWS SDK for Rust (Preview) Java-v2 This issue relates to the AWS SDK for Java V2 labels Nov 28, 2023
@DavidSouther DavidSouther added Rust This issue relates to the AWS SDK for Rust (Preview) On Call Review needed This work needs an on-call review Text Review not needed This contains no text which needs review Task A general update to the code base for language clarification, missing actions, tests, etc. labels Nov 28, 2023
@rlhagerm rlhagerm added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Nov 28, 2023
@rlhagerm rlhagerm merged commit 1843b74 into awsdocs:main Nov 28, 2023
19 of 26 checks passed
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
@DavidSouther @ford-at-aws
Rust: Remove setup tasks that are not needed with larger runners. (#5712
7cf5ee5 
)
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Jan 4, 2024
@DavidSouther @meyertst-aws
Rust: Remove setup tasks that are not needed with larger runners. (aw…
f7e4275 
…sdocs#5712)
@DavidSouther DavidSouther deleted the rust/workers/better_setup branch January 17, 2024 18:56
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
@DavidSouther @max-webster
Rust: Remove setup tasks that are not needed with larger runners. (aw…
69e7eb5 
…sdocs#5712)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyertst-aws meyertst-aws meyertst-aws approved these changes

Assignees

@DavidSouther DavidSouther

Labels
GitHub settings This affects GitHub settings On Call Review complete On call review complete Rust This issue relates to the AWS SDK for Rust (Preview) Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidSouther @meyertst-aws @rlhagerm