Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.NET: Add FM Playground example applications in Amazon Bedrock #5578

Merged
merged 23 commits into from
Nov 7, 2023
Merged

.NET: Add FM Playground example applications in Amazon Bedrock #5578

merged 23 commits into from
Nov 7, 2023

Conversation

fbouteruche
Copy link

This pull request add a cross service .NET example in Amazon Bedrock linking to the .NET FM Playground example application https://github.com/build-on-aws/dotnet-fm-playground.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brmur brmur self-requested a review October 26, 2023 12:38
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
@brmur
Copy link
Contributor

brmur commented Oct 27, 2023

@scmacdon Blocked due to #5543

@brmur brmur mentioned this pull request Oct 27, 2023
Copy link
Contributor

@Laren-AWS Laren-AWS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial feedback.

I also had to update the services list to just bedrock because our system doesn't currently let you specify two bundled services in the same example.

.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/cross-content/cross_FMPlayground_NetV3_block.xml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
@brmur brmur dismissed Laren-AWS’s stale review November 7, 2023 11:37

Changes have been implement. Laren not available.

@brmur brmur added the On Call Review needed This work needs an on-call review label Nov 7, 2023
@DavidSouther DavidSouther added DotNet-v3 This issue relates to the AWS SDK for .NET V3 Text Review not needed This contains no text which needs review Task A general update to the code base for language clarification, missing actions, tests, etc. and removed On Call Review needed This work needs an on-call review labels Nov 7, 2023
@github-actions github-actions bot removed the DotNet-v3 This issue relates to the AWS SDK for .NET V3 label Nov 7, 2023
@brmur brmur added the On Call Review needed This work needs an on-call review label Nov 7, 2023
@DavidSouther DavidSouther added On Call Review complete On call review complete and removed On Call Review needed This work needs an on-call review labels Nov 7, 2023
François Bouteruche and others added 12 commits November 7, 2023 13:08
Co-authored-by: Laren-AWS <[email protected]>
Remove unnecessary blank lines
Adding Scenarios category
Added blank line at bottom to confirm to yamlint.
Removed typo from block name
@DavidSouther DavidSouther merged commit 8e902ae into awsdocs:main Nov 7, 2023
8 checks passed
ford-at-aws pushed a commit that referenced this pull request Dec 15, 2023
Add FM Playground example applications for Amazon Bedrock

---------

Co-authored-by: François Bouteruche <[email protected]>
Co-authored-by: Laren-AWS <[email protected]>
Co-authored-by: Brian Murray <[email protected]>
meyertst-aws pushed a commit to meyertst-aws/aws-doc-sdk-examples that referenced this pull request Jan 4, 2024
…cs#5578)

Add FM Playground example applications for Amazon Bedrock

---------

Co-authored-by: François Bouteruche <[email protected]>
Co-authored-by: Laren-AWS <[email protected]>
Co-authored-by: Brian Murray <[email protected]>
max-webster pushed a commit to max-webster/aws-doc-sdk-examples that referenced this pull request Mar 15, 2024
…cs#5578)

Add FM Playground example applications for Amazon Bedrock

---------

Co-authored-by: François Bouteruche <[email protected]>
Co-authored-by: Laren-AWS <[email protected]>
Co-authored-by: Brian Murray <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Call Review complete On call review complete Task A general update to the code base for language clarification, missing actions, tests, etc. Text Review not needed This contains no text which needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants