Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Java V2 FSA #5362

Merged
merged 68 commits into from
Sep 27, 2023
Merged

Java V2 FSA #5362

merged 68 commits into from
Sep 27, 2023

Conversation

scmacdon
Copy link
Contributor

@scmacdon scmacdon commented Sep 6, 2023

This pull request is a new PR for Java V2 FSA

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@scmacdon scmacdon added On Call Review complete On call review complete Text Review complete Text review complete Java-v2 This issue relates to the AWS SDK for Java V2 labels Sep 6, 2023
@scmacdon scmacdon requested a review from Laren-AWS September 6, 2023 00:17
@scmacdon scmacdon self-assigned this Sep 6, 2023
@github-actions github-actions bot added the GitHub settings This affects GitHub settings label Sep 6, 2023
@scmacdon scmacdon requested review from ford-at-aws and removed request for Laren-AWS September 6, 2023 14:50
ford-at-aws
ford-at-aws previously requested changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@ford-at-aws ford-at-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See requested changes in previous PR, specifically about updating the README. Not seeing that in this new PR.

Laren-AWS
Laren-AWS previously requested changes Sep 11, 2023
View reviewed changes
javav2/usecases/creating_fsa_app/README.md Outdated Show resolved Hide resolved
@scmacdon @meyertst-aws
added transfer manager API
1c9eeec
@scmacdon @meyertst-aws
modified java to use async clients
54ba8a7
@scmacdon @meyertst-aws
modified java to use async clients
67560be
@scmacdon @meyertst-aws
modified java to use async clients
93bd574
@scmacdon @meyertst-aws
modified java to use async clients
3adbb06
@scmacdon @meyertst-aws
modified java to use async clients
8ab73f0
@scmacdon @meyertst-aws
updated the Readme
00bdbb6
@scmacdon @meyertst-aws
updated the Readme
27e4462
@scmacdon @meyertst-aws
updated the Readme
26ffb77
@scmacdon @meyertst-aws
updated the Readme
0ad7ddd
@scmacdon @meyertst-aws
updated the Readme
ce023a6
@scmacdon @meyertst-aws
updated the Readme
d4ac9c5
@scmacdon @meyertst-aws
updated transfer manager logic
50942fa
@scmacdon @meyertst-aws
updated transfer manager logic
bf316a8
@scmacdon @meyertst-aws
updated transfer manager logic
a785b82
@scmacdon @meyertst-aws
add tests
680f3ba
@scmacdon @meyertst-aws
updated POM
0d0ae96
@scmacdon @meyertst-aws
modified TM API code based on SDK team suggestion
558545b
@scmacdon @meyertst-aws
modified tests to test the Service Classes code and make sure they al…
e0d40da 
…l work
@scmacdon @meyertst-aws
modified pom
f8fa366
@scmacdon @meyertst-aws
updated the upload logic using transfer manager
6d74aab
@scmacdon @meyertst-aws
updated the POM in Readme
cb1b89b
@scmacdon @meyertst-aws
updated the POM in Readme
5c48b4f
@scmacdon @meyertst-aws
updated headings in Readme
1bbb175
@scmacdon @meyertst-aws
updated headings in Readme
7110e00
@scmacdon @meyertst-aws
rolled in comments
f59c87c
@scmacdon @meyertst-aws
rolled in comments
63ab0e8
@scmacdon @meyertst-aws
rolled in comments
0c0ffa4
@scmacdon @meyertst-aws
rolled in comments
7c221cb
@meyertst-aws meyertst-aws merged commit 2e09dd8 into awsdocs:main Sep 27, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidSouther DavidSouther DavidSouther left review comments

@cpyle0819 cpyle0819 cpyle0819 approved these changes

@Laren-AWS Laren-AWS Awaiting requested review from Laren-AWS

@ford-at-aws ford-at-aws Awaiting requested review from ford-at-aws

Assignees

@scmacdon scmacdon

Labels
Application An example with multiple AWS Services and SDKs to show how to build a complete, working application. Follow After Scouts, more languages are added to examples as Follows. GitHub settings This affects GitHub settings Java-v2 This issue relates to the AWS SDK for Java V2 On Call Review complete On call review complete Text Review complete Text review complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@scmacdon @DavidSouther @cpyle0819 @Laren-AWS @ford-at-aws @meyertst-aws