Java V2 Added FSA content #5347
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scmacdon
added
On Call Review needed
lkdavies
added
Text Review complete
ford-at-aws
reviewed
Sep 5, 2023
ford-at-aws
requested changes
Sep 5, 2023
There was a problem hiding this comment.
3 things:
1. Majority of README is redundant and possibly should be removed
- Add a line in the FSA README to include language name in implemented languages
3. in need of doc build due to metadata changes
scmacdon
added
On Call Review complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the Java V2 FSA Content.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.