Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflow: build and manage a resilient service using Python #5343

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Workflow: build and manage a resilient service using Python #5343

merged 5 commits into from
Sep 6, 2023

Conversation

Laren-AWS
Copy link
Contributor

@Laren-AWS Laren-AWS commented Aug 30, 2023 •
edited
Loading

  • Create a load-balanced web service that returns recommendations of books, movies, and songs. This example demonstrates how the service responds to failures, and shows ways to restructure the service to be more resilient when failures occur.

This version of the example is missing tests, single action snippets, and a full spec in order to meet publishing deadlines.
Tests, actions, and spec (and any remaining tidbits) will be added as a fast follow.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Laren-AWS Laren-AWS added Python This issue relates to the AWS SDK for Python (boto3) Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs. Scout An example which other languages will use for reference later on. labels Aug 30, 2023
@Laren-AWS Laren-AWS self-assigned this Aug 30, 2023
@Laren-AWS Laren-AWS requested review from rlhagerm, meyertst-aws and scmacdon and removed request for meyertst-aws August 30, 2023 00:02
@Laren-AWS Laren-AWS added On Call Review needed This work needs an on-call review Text Review needed This work needs editorial (text) review labels Aug 30, 2023
meyertst-aws
meyertst-aws approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@meyertst-aws meyertst-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rachel can confirm on this. but we have been requiring single actions SOS for workflows, the way we did for MVP's.
I did not see the single action SOS in this example.

.doc_gen/metadata/cross_metadata.yaml Show resolved Hide resolved
.doc_gen/metadata/services.yaml Show resolved Hide resolved
python/cross_service/resilient_service/load_balancer.py Show resolved Hide resolved
python/cross_service/resilient_service/recommendation_service.py Outdated Show resolved Hide resolved
@Laren-AWS Laren-AWS mentioned this pull request Aug 30, 2023
Merged
3 tasks
rlhagerm
rlhagerm approved these changes Aug 31, 2023
View reviewed changes
python/cross_service/resilient_service/README.md Outdated Show resolved Hide resolved
python/cross_service/resilient_service/README.md Outdated Show resolved Hide resolved
python/cross_service/resilient_service/README.md Outdated Show resolved Hide resolved
python/cross_service/resilient_service/auto_scaler.py Show resolved Hide resolved
python/cross_service/resilient_service/README.md Outdated Show resolved Hide resolved
lkdavies
lkdavies reviewed Aug 31, 2023
View reviewed changes
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/cross_metadata.yaml Outdated Show resolved Hide resolved
.doc_gen/metadata/services.yaml Outdated Show resolved Hide resolved
python/cross_service/resilient_service/README.md Outdated Show resolved Hide resolved
workflows/resilient_service/README.md Outdated Show resolved Hide resolved
workflows/resilient_service/README.md Outdated Show resolved Hide resolved
workflows/resilient_service/README.md Outdated Show resolved Hide resolved
workflows/resilient_service/README.md Outdated Show resolved Hide resolved
@lkdavies lkdavies added Text Review complete Text review complete and removed Text Review needed This work needs editorial (text) review labels Aug 31, 2023
@github-actions github-actions bot added DotNet-v3 This issue relates to the AWS SDK for .NET V3 Kotlin This issue relates to the AWS SDK for Kotlin CDK Relates to the AWS Cloud Development Kit (CDK) GitHub settings This affects GitHub settings labels Sep 1, 2023
@Laren-AWS
Workflow: build and manage a resilient service
141a9d4 
* Create a load-balanced web service that returns recommendations of books, movies, and songs.
This example demonstrates how the service responds to failures, and shows ways to restructure the service to be
more resilient when failures occur.
@Laren-AWS Laren-AWS force-pushed the resilient-architecture-python branch from b6d34c9 to 141a9d4 Compare September 1, 2023 22:51
@github-actions github-actions bot removed DotNet-v3 This issue relates to the AWS SDK for .NET V3 Kotlin This issue relates to the AWS SDK for Kotlin CDK Relates to the AWS Cloud Development Kit (CDK) GitHub settings This affects GitHub settings labels Sep 1, 2023
@Laren-AWS Laren-AWS removed the On Call Review needed This work needs an on-call review label Sep 6, 2023
@Laren-AWS Laren-AWS added the On Call Review complete On call review complete label Sep 6, 2023
@Laren-AWS Laren-AWS merged commit 79ba919 into awsdocs:main Sep 6, 2023
8 checks passed
@Laren-AWS Laren-AWS deleted the resilient-architecture-python branch September 6, 2023 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lkdavies lkdavies lkdavies left review comments

@rlhagerm rlhagerm rlhagerm approved these changes

@meyertst-aws meyertst-aws meyertst-aws approved these changes

@scmacdon scmacdon Awaiting requested review from scmacdon

Assignees

@Laren-AWS Laren-AWS

Labels
On Call Review complete On call review complete Python This issue relates to the AWS SDK for Python (boto3) Scout An example which other languages will use for reference later on. Text Review complete Text review complete Workflow A simple code example to show how certain tasks can be accomplished using several services and SDKs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Laren-AWS @lkdavies @meyertst-aws @rlhagerm