GitHub: Expand yaml-lint.yml (#6571)

.github/allowed-labels.yml

@@ -125,4 +125,3 @@
 - name: Text Review not needed
   color: "f5f7f9"
   description: "This contains no text which needs review"
-

.github/linters/.ruby-lint.yml

@@ -16,4 +16,4 @@ Layout/LineLength:
 Naming/FileName:
   Enabled: false
 Style/HashSyntax:
-  EnforcedShorthandSyntax: either
+  EnforcedShorthandSyntax: either

.github/workflows/docker-push.yml

@@ -5,7 +5,7 @@ permissions:
   contents: read
   id-token: write
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request_target:
     types:
       - closed
@@ -30,7 +30,7 @@ jobs:
       ##################################################
 
       - name: Configure AWS credentials
-        uses: aws-actions/configure-aws-credentials@master # More information on this action can be found below in the 'AWS Credentials' section
+        uses: aws-actions/configure-aws-credentials@master  # More information on this action can be found below in the 'AWS Credentials' section
         with:
           role-to-assume: arn:aws:iam::808326389482:role/automation
           aws-region: us-east-1

.github/workflows/issue-metrics.yml

@@ -6,7 +6,7 @@
 # https://github.com/marketplace/actions/issue-metrics
 
 name: Monthly issue metrics
-on:
+on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
   schedule:
     - cron: '3 2 1 * *'
@@ -20,27 +20,27 @@ jobs:
     name: Issue metrics
     runs-on: ubuntu-latest
     steps:
-    - name: Get dates for last month
-      shell: bash
-      run: |
-        # Calculate the first day of the previous month
-        first_day=$(date -d "last month" +%Y-%m-01)
+      - name: Get dates for last month
+        shell: bash
+        run: |
+          # Calculate the first day of the previous month
+          first_day=$(date -d "last month" +%Y-%m-01)
 
-        # Calculate the last day of the previous month
-        last_day=$(date -d "$first_day +1 month -1 day" +%Y-%m-%d)
+          # Calculate the last day of the previous month
+          last_day=$(date -d "$first_day +1 month -1 day" +%Y-%m-%d)
 
-        #Set an environment variable with the date range
-        echo "last_month=$first_day..$last_day" >> "$GITHUB_ENV"
+          # Set an environment variable with the date range
+          echo "last_month=$first_day..$last_day" >> "$GITHUB_ENV"
 
-    - name: Run issue-metrics tool
-      uses: github/issue-metrics@v2
-      env:
-        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-        SEARCH_QUERY: 'repo:awsdocs/aws-doc-sdk-examples is:issue created:${{ env.last_month }} -reason:"not planned"'
+      - name: Run issue-metrics tool
+        uses: github/issue-metrics@v2
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          SEARCH_QUERY: 'repo:awsdocs/aws-doc-sdk-examples is:issue created:${{ env.last_month }} -reason:"not planned"'
 
-    - name: Create issue
-      uses: peter-evans/create-issue-from-file@v5
-      with:
-        title: Monthly issue metrics report  ${{ env.last_month }}
-        token: ${{ secrets.GITHUB_TOKEN }}
-        content-filepath: ./issue_metrics.md
+      - name: Create issue
+        uses: peter-evans/create-issue-from-file@v5
+        with:
+          title: Monthly issue metrics report  ${{ env.last_month }}
+          token: ${{ secrets.GITHUB_TOKEN }}
+          content-filepath: ./issue_metrics.md

.github/workflows/label-auditor.yml

@@ -1,6 +1,6 @@
 name: "Audit Labels"
 
-on:
+on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
   pull_request:
     branches:
@@ -16,8 +16,7 @@ jobs:
     runs-on: ubuntu-latest
     if: github.event.pull_request.merged == true
     steps:
-      -
-        name: Checkout
+      - name: Checkout
         uses: actions/checkout@v3
         with:
           sparse-checkout: .github/allowed-labels.yml
@@ -31,8 +30,7 @@ jobs:
       #
       # For more information, see:
       # https://github.com/crazy-max/ghaction-github-labeler
-      -
-        name: Audit Labels
+      - name: Audit Labels
         if: success()
         uses: crazy-max/ghaction-github-labeler@v4
         with:

.github/workflows/label-auto-language.yml

@@ -1,6 +1,6 @@
 name: "Auto Labeler"
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request_target:
     branches:
       - main
@@ -12,8 +12,7 @@ jobs:
       pull-requests: write
     runs-on: ubuntu-latest
     steps:
-      -
-        name: Checkout
+      - name: Checkout repository
         uses: actions/checkout@v3
 
       # The Add Labels workflow adds a label to pull requests
@@ -24,9 +23,8 @@ jobs:
       #
       # For more information, see:
       # https://github.com/actions/labeler
-      -
-       name: Add Labels
-       uses: actions/labeler@v4
-       with:
-         repo-token: "${{ secrets.GITHUB_TOKEN }}"
-         configuration-path: .github/label-ruleset.yml
+      - name: Add Labels
+        uses: actions/labeler@v4
+        with:
+          repo-token: "${{ secrets.GITHUB_TOKEN }}"
+          configuration-path: .github/label-ruleset.yml

.github/workflows/label-checker.yml

@@ -1,6 +1,5 @@
----
 name: Label Checker
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request:
     branches:
       - main
@@ -12,7 +11,6 @@ on:
       - unlabeled
 
 jobs:
-
   check_oncall_labels:
     name: Check On Call Review labels
     runs-on: ubuntu-latest

.github/workflows/dotnet-check.yml → .github/workflows/lint-check-dotnet.yml

@@ -1,5 +1,6 @@
-name: Dotnet lint check
-on:
+name: Dotnet Lint and Check
+
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 permissions:

.github/workflows/golangci-lint.yml → .github/workflows/lint-golang.yml

@@ -1,5 +1,6 @@
-name: golangci-lint
-on:
+name: Lint GoLang
+
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 permissions:
@@ -29,7 +30,6 @@ jobs:
         run: curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.47.3
       - name: run golangci-lint
         if: steps.changed-files.outputs.any_changed == 'true'
-          # If you get a linting error of "File is not `goimports`-ed", the solution is to run "gofmt -w ./<folder>".
-        run: |
+        run: |  # If you get a linting error of "File is not `goimports`-ed", the solution is to run "gofmt -w ./<folder>".
           cd gov2
           ./lint_all_go.sh

.github/workflows/javascript.yml → .github/workflows/lint-javascript.yml

@@ -1,6 +1,6 @@
 name: JavaScript
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 
@@ -36,4 +36,4 @@ jobs:
         if: steps.changed-files.outputs.any_changed == 'true'
         run: |
           changed_files=(${{steps.changed-files.outputs.all_changed_files}})
-          ./javascriptv3/github_scripts/lint.sh "${changed_files[@]}"
+          ./javascriptv3/github_scripts/lint.sh "${changed_files[@]}"

.github/workflows/kotlin-lint.yml → .github/workflows/lint-kotlin.yml

@@ -1,6 +1,6 @@
 name: Kotlin Linter
 
-on:
+on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
   pull_request:
 
@@ -12,7 +12,7 @@ jobs:
       - name: Checkout files
         uses: actions/checkout@v4
         with:
-            fetch-depth: 0
+          fetch-depth: 0
       - name: Get changed files
         id: changed-files
         uses: tj-actions/changed-files@v41
@@ -34,4 +34,3 @@ jobs:
         run: |
           ktlint --reporter=plain?group_by_file --editorconfig=".github/linters/ktlint_config"
         continue-on-error: false
-

.github/workflows/php-lint.yml → .github/workflows/lint-php.yml

@@ -1,6 +1,7 @@
 name: "PHP Linter"
 
-on:
+on:  # yamllint disable-line rule:truthy
+  workflow_dispatch:
   pull_request:
     paths:
       - "**.php"
@@ -12,7 +13,8 @@ jobs:
     name: "PHP Linter"
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - name: Checkout repository
+        uses: actions/checkout@v2
         with:
           fetch-depth: 0
 
@@ -28,7 +30,8 @@ jobs:
           curl -OL https://squizlabs.github.io/PHP_CodeSniffer/phpcs.phar
           php phpcs.phar --version
 
-      - uses: thenabeel/action-phpcs@v8
+      - name: Run PHPCS
+        uses: thenabeel/action-phpcs@v8
         if: steps.changed-files.outputs.any_changed == 'true'
         with:
           files: "**.php"

.github/workflows/python.yml → .github/workflows/lint-python.yml

@@ -1,6 +1,6 @@
 name: Lint Python
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 

.github/workflows/ruby.yml → .github/workflows/lint-ruby.yml

@@ -1,6 +1,6 @@
 name: Ruby Linting
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 

.github/workflows/rust.yml → .github/workflows/lint-rust.yml

@@ -1,5 +1,6 @@
-name: Rust
-on:
+name: Lint - Test - Format Rust
+
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 permissions:

.github/workflows/pr_stats.yml

@@ -1,6 +1,6 @@
 name: Pull Request Stats
 
-on:
+on:  # yamllint disable-line rule:truthy
   workflow_dispatch:
 
 jobs:

.github/workflows/sd-cpp-lint.yml

@@ -1,5 +1,5 @@
-name: "cpp lint check"
-on:
+name: "Lint C++"
+on:   # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 

.github/workflows/sh-check.yml

@@ -2,7 +2,7 @@
 
 name: Lint Bash
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 

.github/workflows/validate-doc-metadata.yml

@@ -1,14 +1,12 @@
 name: Validate Documentation Metadata
 
-on:
+on:  # yamllint disable-line rule:truthy
+  workflow_dispatch:
   push:
     branches: [main]
   pull_request:
     branches: [main]
 
-  # Allows running this workflow manually from the Actions tab
-  workflow_dispatch:
-
 jobs:
   validate-doc-metadata:
     name: Validate Doc Metadata

.github/workflows/writeme.yml

@@ -1,7 +1,7 @@
 name: Validate WRITEMEs
 
 # Controls when the action will run.
-on:
+on:  # yamllint disable-line rule:truthy
   # Triggers the workflow on push or pull request events but only for the main branch
   push:
     branches: [main]
@@ -21,12 +21,12 @@ jobs:
 
     # Steps represent a sequence of tasks that will be executed as part of the job
     steps:
-      - name: checkout repo content
-        uses: actions/checkout@v3 # checkout the repository content to github runner.
-      - name: setup python
+      - name: Checkout repo content
+        uses: actions/checkout@v3  # checkout the repository content to github runner.
+      - name: Setup Python
         uses: actions/setup-python@v3
         with:
-          python-version: 3.11 #install the python needed
+          python-version: 3.11  # install the python needed
       - name: Install dependencies
         run: >-
           python3 -m pip install -r .tools/readmes/requirements.txt

.github/workflows/yaml-lint.yml

@@ -1,6 +1,6 @@
-name: Lint Metadata Yaml
+name: Lint Yaml
 
-on:
+on:  # yamllint disable-line rule:truthy
   pull_request:
   workflow_dispatch:
 
@@ -20,7 +20,7 @@ jobs:
         id: changed-files
         uses: tj-actions/changed-files@v41
         with:
-          files: ".doc_gen/metadata/**/*.{yml,yaml}"
+          files: "**/*.{yml,yaml}"
       - name: Setup Python
         if: steps.changed-files.outputs.any_changed == 'true'
         uses: actions/setup-python@v3
@@ -30,7 +30,7 @@ jobs:
         if: steps.changed-files.outputs.any_changed == 'true'
         run: >-
           python3 -m pip install -r .tools/base_requirements.txt
-      - name: Lint metadata files
+      - name: Lint YAML files
         if: steps.changed-files.outputs.any_changed == 'true'
         run: >-
-          yamllint --format standard -c .tools/validation/.yamllint.yaml .doc_gen/metadata
+          yamllint --format standard -c .tools/validation/.yamllint.yaml .

.tools/test/stacks/config/targets.yaml

@@ -13,10 +13,10 @@ javascriptv3:
   account_id: "875008041426"
   status: "enabled"
 javav2:
-  account_id: "667348412466" # back-up "814548047983"
+  account_id: "667348412466"  # back-up "814548047983"
   status: "enabled"
 kotlin:
-  account_id: "471951630130" # back-up "814548047983"
+  account_id: "471951630130"  # back-up "814548047983"
   status: "enabled"
 php:
   account_id: "733931915187"