feat: implement smithy reference arch for identity and auth resolution #469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaiahvita
approved these changes
Nov 8, 2023
syall
approved these changes
Nov 8, 2023
| * Middleware to set the final operation input on the context at the start of the serialize step such that protocol | ||
| * middlewares in later phases can use it. | ||
| */ | ||
| public class SetOperationInputContextMiddleware { |
There was a problem hiding this comment.
more of a nit, but does this need its own middleware if it's just a 1-line op? why not inline?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the final merge candidate for SRA identity and auth.
It is more or less the sum of all the previous PRs against the
feat-sraauthbranch, except I removed the sugar around constructing auth options. I wasn't particularly happy with that (had concerns about differentiating between zero values and unset), they weren't at all necessary either since you can create auth options directly.The most important thing here is to review the API surface and make sure we're ready to commit.