pom.xml missing references fix #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deki
requested changes
Jan 23, 2024
| @@ -55,7 +55,7 @@ | |||
| <plugin> | |||
| <groupId>org.apache.maven.plugins</groupId> | |||
| <artifactId>maven-shade-plugin</artifactId> | |||
| <version>3.5.1</version> | |||
| <version>3.5.0</version> | |||
There was a problem hiding this comment.
No need to downgrade or were you facing any issues with the latest version?
There was a problem hiding this comment.
3.5.0 Was being marked as not found, so I downgraded to the suggested version.
Plugin 'org.apache.maven.plugins:maven-shade-plugin:3.5.1' not found
There was a problem hiding this comment.
I was able to build just fine though, but the warning does not go away.
There was a problem hiding this comment.
Maybe related to your local cache? It's available in central: https://repo1.maven.org/maven2/org/apache/maven/plugins/maven-shade-plugin/3.5.1/
Can you please remove the change from the PR? I will merge afterwards. Thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing maven references on Pet-Store sample project