Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Multipart files processing when Array of files with same fieldName is sent in request #675

Merged
merged 2 commits into from
Nov 3, 2023
Merged

Fix: Multipart files processing when Array of files with same fieldName is sent in request #675

merged 2 commits into from
Nov 3, 2023

Conversation

mbfreder
Copy link
Contributor

@mbfreder mbfreder commented Nov 3, 2023

Issue #, if available: #633

Description of changes:

Fixed Multipart files processing issue occurring when Array of files with same fieldName is sent in the request.

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@mbfreder mbfreder requested a review from deki November 3, 2023 00:43
deki
deki requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@deki deki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getParts and getPart are identical in AwsProxyHttpServletRequest and AwsHttpApiV2ProxyHttpServletRequest. Please move them up to AwsHttpServletRequest.

@mbfreder
Copy link
Contributor Author

mbfreder commented Nov 3, 2023

Done.

@deki deki merged commit 8b069b2 into aws:main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deki deki deki requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbfreder @deki