Add delegation proxy to spring web proxy #578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows for separation of responsibilty between AWS and Spring where AWS side remains responsible to create HttpServletRequest from JSON representation of the API Gateway's input stream. Once created it can now delegate to Spring provided module for further interaction with the DispatcherServlet and the rest of thet Spring stack Introduce a boolean flag to disable delegation to Spring
|
Hi @olegz, we haven't had much time to review recently, but I should be able to take a look soon. One thing that I'm seeing is that one of the test suites is failing (Build and test Spring, it looks like a dependency conflict). If you can take a look at that while I review the rest of the code. Thanks. |
|
@valerena I am now thinking. Should it really be against aws-serverless-java-container-springboot3? I believe so. Please let me know |
|
Closing it in favor of a new PR that i'll be submitting soon which will simply be an implementation of RequestStreamHandler specific to Spring code. This way no boolean flag will be necessary and user can choose which handler to use. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows for separation of responsibility between AWS and Spring where AWS side remains responsible to create HttpServletRequest from JSON representation of the API Gateway's input stream. Once created it can now delegate to Spring provided module for further interaction with the DispatcherServlet and the rest of the Spring stack
This has been long discussed with @msailes and greater AWS team