Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load using the application class loader #550

Merged
merged 1 commit into from
Apr 28, 2023

Conversation

Artur-
Copy link
Contributor

@Artur- Artur- commented Apr 28, 2023

By using the class loader from the servlet context to load the servlet class, the servlet class will be able to find its resources from the class path.

Fixes #506

By submitting this pull request

  • I confirm that my contribution is made under the terms of the Apache 2.0 license.
  • I confirm that I've made a best effort attempt to update all relevant documentation.

@Artur-
Copy link
Contributor Author

Artur- commented Apr 28, 2023

I don't have a good idea on how to add a test for this except for maybe a test that asserts the class loaders for the servlet and the servlet context are the same

@deki deki merged commit 935b9d8 into aws:main Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Servlet class loaded with the wrong class loader
2 participants