Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix: Log request time from ALB requests #270

Merged
merged 1 commit into from
Sep 30, 2019
Merged

Bug Fix: Log request time from ALB requests #270

merged 1 commit into from
Sep 30, 2019

Conversation

goughy000
Copy link
Contributor

Issue #, if available: N/A

Description of changes:

  • Previously logged as 01/01/1970:00:00:00Z as RequestTimeEpoch is == 0 (default) for ALB requests
  • Added some tests to cover the fix

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

- Previously logged as 01/01/1970:00:00:00Z as RequestTimeEpoch == 0
Copy link
Collaborator

@sapessi sapessi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. We'll merge it with the next release (1.4).

@goughy000
Copy link
Contributor Author

Thanks @sapessi - I will keep my eyes peeled for 1.4 release

@sapessi sapessi added this to the Release 1.4 milestone Jul 31, 2019
@sapessi sapessi merged commit ac789a1 into aws:master Sep 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants