Duplicate values in the AwsProxyHttpServletRequest.getParameterMap()

[avinashbitra]

File: AwsProxyHttpServletRequest

@OverRide
public Map<String, String[]> getParameterMap() {
Map<String, String[]> output = new HashMap<>();
Map<String, List> params = urlEncodedFormParameters
.....
if (params.containsKey(entry.getKey())) {
params.get(entry.getKey()).add(entry.getValue());
}
.....

urlEncodedFormParameters are initialized in the constructor and getParameterMap whenever invoked keeps adding to the same Map which ends up in having duplicate values.

Map<String, List> params = this.getFormUrlEncodedParametersMap();
should reset the params map.

[sapessi]

Hey @avinashbitra, can you share what the original request you sent looks like?

[avinashbitra]

@sapessi
Its a http GET request with query parameters for spring rest repositories
http://hostname/repo/search/findByParam?&param=value

[avinashbitra]

@sapessi issue here is inside the spring framework while using spring rest repositories and making a http get request with query parameters, framework is trying to map the request parameters to method parameters.

While framework is trying to map the parameters, it makes multiple request.getParameterMap() invocations and because of the above code we are seeing duplicate values for a parameter and ends up with wrong parameter value passed to the method.

[avinashbitra]

@sapessi Is there any update on this.

[sapessi]

Hey @avinashbitra, I'll try to get this fixed for the next release of the framework. I'm at home on Paternity leave for the next 2 weeks.

[avinashbitra]

Thanks @sapessi

[sapessi]

The latest commit addresses this issue. I'm closing this for the time being.