change: Support protobuf4 #3985

claytonparnell · 2023-07-07T19:22:22Z

Issue #, if available: #3592

Description of changes: Update to support protobuf4, and regenerate record_pb2 to support.
Generating record_pb2.py using grpcio-tools==1.48.1, uses protoc 3.19.4, which supports both protobuf 3.x and protobuf 4.x (see open-telemetry/opentelemetry-python#3070). Raised lowerbound of protobuf to correspond with lower bound of grpcio-tools==1.48.1.
Also upgrade importlib-metadata upper bound, and loosen PyYAML to include 6.x.

Testing done:

Merge Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.

General

I have read the CONTRIBUTING doc
I certify that the changes I am introducing will be backward compatible, and I have discussed concerns about this, if any, with the Python SDK team
I used the commit message format described in CONTRIBUTING
I have passed the region in to all S3 and STS clients that I've initialized as part of this change.
I have updated any necessary documentation, including READMEs and API docs (if appropriate)

Tests

I have added tests that prove my fix is effective or that my feature works (if appropriate)
I have added unit and/or integration tests as appropriate to ensure backward compatibility of the changes
I have checked that my tests are not configured for a specific region or account (if appropriate)
I have used unique_name_from_base to create resource names in integ tests (if appropriate)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sagemaker-bot · 2023-07-07T19:28:28Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 1a9f31d
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T19:46:13Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 6554802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T20:16:47Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 6554802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T20:28:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 6554802
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T20:32:14Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 6554802
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T21:32:44Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 0e2f799
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

src/sagemaker/amazon/common.py

sagemaker-bot · 2023-07-07T22:19:37Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: de5f799
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T22:23:12Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: de5f799
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T22:31:23Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: de5f799
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T23:26:52Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d92e87a
Result: FAILED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T23:27:08Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: d92e87a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-07T23:39:45Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: d92e87a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-08T00:20:10Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: d92e87a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

codecov-commenter · 2023-07-08T02:15:51Z

Codecov Report

Merging #3985 (46effc9) into master (a8b6b1d) will decrease coverage by 0.87%.
The diff coverage is 29.82%.

@@            Coverage Diff             @@
##           master    #3985      +/-   ##
==========================================
- Coverage   90.32%   89.45%   -0.87%     
==========================================
  Files        1296      306     -990     
  Lines      114132    28221   -85911     
==========================================
- Hits       103088    25246   -77842     
+ Misses      11044     2975    -8069

Impacted Files	Coverage Δ
src/sagemaker/amazon/record_pb2.py	`43.66% <23.07%> (ø)`
src/sagemaker/clarify.py	`97.49% <100.00%> (ø)`
src/sagemaker/djl_inference/model.py	`91.11% <100.00%> (ø)`

... and 1599 files with indirect coverage changes

sagemaker-bot · 2023-07-08T02:15:55Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: d92e87a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-10T17:57:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: d92e87a
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-10T21:18:06Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 887f74f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-10T21:22:41Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 887f74f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-10T21:35:33Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 887f74f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-10T22:15:26Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 887f74f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-11T00:19:09Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 887f74f
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T16:37:57Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-notebook-tests
Commit ID: 46effc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T16:41:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-pr
Commit ID: 46effc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T16:50:49Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-local-mode-tests
Commit ID: 46effc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T17:36:48Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-unit-tests
Commit ID: 46effc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

sagemaker-bot · 2023-07-12T19:26:58Z

AWS CodeBuild CI Report

CodeBuild project: sagemaker-python-sdk-slow-tests
Commit ID: 46effc9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Support protobuf4

1a9f31d

claytonparnell requested a review from a team as a code owner July 7, 2023 19:22

claytonparnell requested review from zuoyuanh and removed request for a team July 7, 2023 19:22

claytonparnell linked an issue Jul 7, 2023 that may be closed by this pull request

Support protobuf 4 #3592

Closed

formatting...

6554802

claytonparnell added 3 commits July 7, 2023 14:26

Ignore pylint

22cc812

Add .proto file for ref

64c2fce

Add pyi file

0e2f799

more formatting..

de5f799

claytonparnell commented Jul 7, 2023

View reviewed changes

src/sagemaker/amazon/common.py Outdated Show resolved Hide resolved

Raise lower bound of protobuf

d92e87a

Support protobuf 3 AND 4

887f74f

claytonparnell requested a review from navinsoni July 11, 2023 20:01

Update lower bound to ensure compatibility. Loosen PyYAML

46effc9

claytonparnell removed the request for review from navinsoni July 12, 2023 17:21

zuoyuanh approved these changes Jul 12, 2023

View reviewed changes

sthodimi merged commit 53fe9b7 into aws:master Jul 12, 2023

humanzz mentioned this pull request Aug 8, 2023

DeprecationWarning: Call to deprecated create function FieldDescriptor(). Note: Create unlinked descriptors is going to go away. Please use get/find descriptors from generated code or query the descriptor_pool. #3367

Closed

trungleduc mentioned this pull request Sep 25, 2023

setup.py sets upper bound on importlib-metadata #3147

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

change: Support protobuf4 #3985

change: Support protobuf4 #3985

claytonparnell commented Jul 7, 2023 •

edited

Loading

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 7, 2023

sagemaker-bot commented Jul 8, 2023

codecov-commenter commented Jul 8, 2023 •

edited

Loading

sagemaker-bot commented Jul 8, 2023

sagemaker-bot commented Jul 10, 2023

sagemaker-bot commented Jul 10, 2023

sagemaker-bot commented Jul 10, 2023

sagemaker-bot commented Jul 10, 2023

sagemaker-bot commented Jul 10, 2023

sagemaker-bot commented Jul 11, 2023

sagemaker-bot commented Jul 12, 2023

sagemaker-bot commented Jul 12, 2023

sagemaker-bot commented Jul 12, 2023

sagemaker-bot commented Jul 12, 2023

sagemaker-bot commented Jul 12, 2023

change: Support protobuf4 #3985

change: Support protobuf4 #3985

Conversation

claytonparnell commented Jul 7, 2023 • edited Loading

Merge Checklist

General

Tests

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 7, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 8, 2023

AWS CodeBuild CI Report

codecov-commenter commented Jul 8, 2023 • edited Loading

Codecov Report

sagemaker-bot commented Jul 8, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 10, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 11, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

sagemaker-bot commented Jul 12, 2023

AWS CodeBuild CI Report

claytonparnell commented Jul 7, 2023 •

edited

Loading

codecov-commenter commented Jul 8, 2023 •

edited

Loading