Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add amazon-sagemaker-jupyter-ai-q-developer and others #447

Merged
merged 2 commits into from
Jun 24, 2024

Conversation

kumarnzt
Copy link
Contributor

Add amazon-sagemaker-jupyter-ai-q-developer and others amazon-q-developer-jupyterlab-ext.

Issue #, if available:

Description of changes:
Adding new dependencies and bumping others as follows:

  1. amazon-sagemaker-jupyter-ai-q-developer[version='>=1.0.3,<2.0'] - new extension

  2. amazon-q-developer-jupyterlab-ext[version='>=3.1.0,<4.0'] - new extension for CW

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@claytonparnell
Copy link
Contributor

Can you please add unit tests for these packages?

@kumarnzt
Copy link
Contributor Author

Added tests for new packages.

@dylanraws
Copy link

I see the tests simply import the packages. Is it possible to test one or more actual features of these packages? In the event that another change in the image affects deeper functionality of these new packages, a simple import may not catch that.

@TRNWWZ
Copy link
Contributor

TRNWWZ commented Jun 21, 2024

Why is amazon_codewhisperer_jupyterlab_ext removed from the unit test, is it no longer used?

@kumarnzt
Copy link
Contributor Author

Why is amazon_codewhisperer_jupyterlab_ext removed from the unit test, is it no longer used?

Yes, amazon_codewhisperer_jupyterlab_ext is no longer used and needs to be removed. amazon-q-developer-jupyterlab-ext is a replacement for it which is added.

@kumarnzt
Copy link
Contributor Author

I see the tests simply import the packages. Is it possible to test one or more actual features of these packages? In the event that another change in the image affects deeper functionality of these new packages, a simple import may not catch that.

Testing functional features require getting the AmazonQ SSO credentials (to be able to make chat calls). We should be good with these now to confirm that SMD is not breaking, I will take a look at feasibility for extension functionality testing separately.

@claytonparnell claytonparnell merged commit aae147a into aws:main Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants