Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mlflow package #441

Merged
merged 6 commits into from
Jun 14, 2024
Merged

Add mlflow package #441

merged 6 commits into from
Jun 14, 2024

Conversation

saimidu
Copy link
Contributor

@saimidu saimidu commented Jun 13, 2024

Issue #, if available:

Description of changes:
Add mlflow package to cpu and gpu dockerfiles for v2.0.0

Test result:

$ python -m pytest -n auto -m cpu -vv -rs -k "mlflow" --local-image-version $VERSION
================================================================= test session starts ==================================================================
platform linux -- Python 3.12.3, pytest-8.2.2, pluggy-1.5.0 -- /home/saimidu/miniconda3/envs/sagemaker-distribution/bin/python
cachedir: .pytest_cache
rootdir: /local/home/saimidu/sagemaker-distribution
configfile: pytest.ini
plugins: xdist-3.6.1, mock-3.14.0
8 workers [1 item]
scheduling tests via LoadScheduling

test/test_dockerfile_based_harness.py::test_dockerfiles_for_cpu[mlflow.test.Dockerfile-required_packages27]
[gw0] [100%] PASSED test/test_dockerfile_based_harness.py::test_dockerfiles_for_cpu[mlflow.test.Dockerfile-required_packages27]

=================================================================== warnings summary ===================================================================
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
../../../../home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426
  /home/saimidu/miniconda3/envs/sagemaker-distribution/lib/python3.12/site-packages/boltons/timeutils.py:426: DeprecationWarning: datetime.datetime.utcfromtimestamp() is deprecated and scheduled for removal in a future version. Use timezone-aware objects to represent datetimes in UTC: datetime.datetime.fromtimestamp(timestamp, datetime.UTC).
    EPOCH_NAIVE = datetime.utcfromtimestamp(0)

src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
src/utils.py:4
  /local/home/saimidu/sagemaker-distribution/src/utils.py:4: DeprecationWarning: conda.cli.python_api is deprecated and will be removed in 24.9. Use `conda.testing.conda_cli` instead.
    import conda.cli.python_api

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================== 1 passed, 16 warnings in 380.90s (0:06:20) ======================================================

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@saimidu
Copy link
Contributor Author

saimidu commented Jun 13, 2024

The cpu/gpu.env.in files are not up-to-date due to having incorrectly placed the additional_packages_env file in the 2.0.0_beta folder instead of 2.0.0. Fixing this now, and regenerating the images/files locally to push to PR branch.

@claytonparnell
Copy link
Contributor

Tested install on top of 1.8 image; no dependency issues, 10MB total (uncompressed) change.


RUN python -c "import mlflow"

RUN sudo apt-get update && sudo apt-get install -y git && \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Git is already present. we don't need that

@claytonparnell claytonparnell merged commit 20ae772 into aws:main Jun 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants