Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add openssl-1.0.2-fips to fuzz test #4942

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

boquan-fang
Copy link
Contributor

Description of changes:

buildspec_fuzz_batch.yml is lacking openssl-1.0.2-fips coverage. However, that libcrypto is tested in buildspec_omnibus.yml.

- identifier: s2nFuzzerOpenSSL102FIPS
buildspec: codebuild/spec/buildspec_ubuntu_fuzz_artifacts.yml
env:
privileged-mode: true
compute-type: BUILD_GENERAL1_LARGE
image: 024603541914.dkr.ecr.us-west-2.amazonaws.com/docker:ubuntu22codebuild
variables:
S2N_LIBCRYPTO: openssl-1.0.2-fips
LATEST_CLANG: true
TESTS: fuzz
FUZZ_TIMEOUT_SEC: 60

We need to add a test for openssl-1.0.2-fips in fuzz test to fill that coverage.

Call-outs:

AWS-LC fips is another fips libcrypto that we have. However, we are not testing that in fuzz test because of compilation issue. Refer to issue #4800 for detail description of that problem.

Testing:

This change will be tested in CodeBuild s2nFuzzBatch.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Dec 2, 2024
@boquan-fang boquan-fang requested a review from jouho December 3, 2024 00:16
@boquan-fang boquan-fang marked this pull request as ready for review December 3, 2024 00:20
@boquan-fang boquan-fang requested a review from dougch as a code owner December 3, 2024 00:20
@boquan-fang boquan-fang enabled auto-merge (squash) December 3, 2024 18:11
@boquan-fang boquan-fang merged commit 97f4c7c into aws:main Dec 3, 2024
38 checks passed
@boquan-fang boquan-fang deleted the add-fips-to-fuzz branch December 18, 2024 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants