Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade cmake version to 3.9 #4933

Merged
merged 1 commit into from
Nov 26, 2024
Merged

upgrade cmake version to 3.9 #4933

merged 1 commit into from
Nov 26, 2024

Conversation

jouho
Copy link
Contributor

@jouho jouho commented Nov 26, 2024

Release Summary:

Updated CMake version from 3.0 to 3.9.

Resolved issues:

resolves #4899

Description of changes:

Updated the cmake_minimum_required version from 3.0 to 3.9.

Call-outs:

Testing:

Before this change, you'd see following warning when you build s2n-tls:

~/s2n-tls$ cmake . -Bbuild     -DCMAKE_BUILD_TYPE=Release     -DCMAKE_INSTALL_PREFIX=./s2n-tls-install
CMake Deprecation Warning at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value or use a ...<max> suffix to tell
  CMake that the project does not need compatibility with older versions.


-- Detected CMAKE_SYSTEM_PROCESSOR as x86_64
-- Detected 64-Bit system
-- LibCrypto Include Dir: /usr/include
...

After this change, the warning message is gone:

~/s2n-tls$ cmake . -Bbuild     -DCMAKE_BUILD_TYPE=Release     -DCMAKE_INSTALL_PREFIX=./s2n-tls-install
-- Detected CMAKE_SYSTEM_PROCESSOR as x86_64
-- Detected 64-Bit system
-- LibCrypto Include Dir: /usr/include
...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jouho jouho marked this pull request as ready for review November 26, 2024 01:15
Copy link
Contributor

@maddeleine maddeleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine as long as all tests pass.

Copy link
Contributor

@boquan-fang boquan-fang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests (except the team labeler) pass. Hence, approve this PR.

@jouho jouho merged commit 8ab5899 into aws:main Nov 26, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Cmake version to 3.9
3 participants