ci(nix): Fix integ pq test in a devShell #4576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Partial for #3841
Description of changes:
In the pq integration test, we're hard coding a relative path in the test. Nix is already adding this to the path in the devShell, and for the standalone CodeBuild jobs, this PR moves the PATH change out of the test and into s2n_setup_env.sh.
Call-outs
Turns on PQ builds under nix.
Current CI has pinned aws-lc to version 1.17.4, to get parity with the current test, I made another aws-lc fork flake pinned to the same version.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? locally, CI - AdHoc Nix job
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.