Fixes failing FreeBSD build in CI #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddeleine
changed the title
maddeleine
changed the title
lrstewart
approved these changes
Oct 31, 2023
dougch
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
N/A
Description of changes:
Our FreeBSD builds are hanging. It seems like the workflow doesn't go past 20 minutes normally. We recently changed how we run our FreeBSD github action. During that switch, we explicitly set the version to FreeBSD 13.2. However, previously we were using vmactions/[email protected]. This action did not add support for FreeBSD 13.2 until this June, in v0.3.1. I suspect that we accidentally bumped the version of FreeBSD we were running when we switched to the new github action.
So essentially getting us back to 13.1 should get the CI working again, and we have more investigation to do if we want to support 13.2. I also added a timeout because this action should not be going longer than that.
Callouts
Note that this is not the only issue with this action. I've seen this other failure as well: cross-platform-actions-64, although it can be fixed with a retry.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.