ktls: forbid renegotiation #4229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
force-pushed
the
ktls_reneg
branch
from
645ffc1 to
d740ae3
Compare
lrstewart
force-pushed
the
ktls_reneg
branch
from
d740ae3 to
bdbcaab
Compare
maddeleine
reviewed
Oct 4, 2023
maddeleine
approved these changes
Oct 4, 2023
jmayclin
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
related to #3711
Description of changes:
Small change to prevent ktls from being enabled if the application might be using renegotiation.
I also added some checks to catch if the application DOES try to initiate renegotiation while using ktls, but those checks should never trigger. We should prevent ktls from being enabled if there's any chance of renegotiation. The original use case for renegotiation support was servers that required renegotiation (as in, the connection failed without it), so we don't want to enable ktls if that might be the case because we can't disable it later.
Testing:
Unit test
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.