ktls: fix flaky test #4214
Merged
ktls: fix flaky test #4214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
I used the random test data for my test alert thinking "oh I just care about the record type", but when we get unlucky the random test data looks like a close_notify or a user_canceled instead of an actual fatal alert. Silly mistake 😅
Testing:
I ran the test in the loop for ~30min with no failures. Previously it was failing when run in a loop for <1min.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.