Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4171
Description of changes:
Add a wrapper method for sendfile.
There are actually multiple definitions of sendfile:
ssize_t sendfile(int out_fd, int in_fd, off_t *_Nullable offset, size_t count);
int sendfile(int fd, int s, off_t offset, size_t nbytes, struct sf_hdtr *hdtr, off_t *sbytes, int flags);
int sendfile(int fd, int s, off_t offset, off_t *len, struct sf_hdtr *hdtr, int flags);
We only need to support Linux for now, since we only support ktls in Linux. However, we need to ensure that the signature we choose can work for all implementations. So I dropped any feature only supported by one implementation, like Linux's special handling of offset==NULL and the sf_hdtr field. Our signature should be as minimal as possible.
Call-outs:
Why not just let customers call sendfile directly? This would prevent us from ever updating the connection in response to a send (like if we track bytes sent) and from sending control messages like post-handshake messages.
Testing:
A little unit test that tests sendfile without ktls actually enabled. It tries to send itself :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.