ci: buildspec for qemu ktls test #4175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Aug 29, 2023
lrstewart
reviewed
Aug 29, 2023
codebuild/spec/buildspec_ktls.yml
Outdated
Comment on lines
4
to
5
| build-list: | ||
| - identifier: UnitQEMUkTLS |
There was a problem hiding this comment.
We're minimally also going to need ASAN. Is that doable with this structure?
There was a problem hiding this comment.
it's just a label, but it could be more generic
There was a problem hiding this comment.
I wasn't commenting on the name so much as how well this could be extended to other builds, particularly ASAN.
lrstewart
reviewed
Aug 29, 2023
dougch
force-pushed
the
ktls_buildspec
branch
4 times, most recently
from
bc16f9e to
158d2fc
Compare
lrstewart
reviewed
Aug 30, 2023
|
Runtime for a full unit test pass came in at 30 minutes codebuild |
dougch
force-pushed
the
ktls_buildspec
branch
2 times, most recently
from
fa6677f to
a148f78
Compare
lrstewart
approved these changes
Aug 31, 2023
maddeleine
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
partial for #3711 3711
Description of changes:
First draft at a ktls unit test, using an AL2 image running with qemu.
Call-outs:
There are multiple places for optimization, this is MVP.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? local and ad-hoc CodeBuild job
Is this a refactor change? no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.