-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kTLS: implement recvmsg #4154
Merged
Merged
kTLS: implement recvmsg #4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toidiu
force-pushed
the
ak-ktls1_recvmsg
branch
5 times, most recently
from
August 22, 2023 06:17
4f4452f
to
41adc0a
Compare
lrstewart
reviewed
Aug 22, 2023
maddeleine
reviewed
Aug 22, 2023
maddeleine
reviewed
Aug 23, 2023
toidiu
force-pushed
the
ak-ktls1_recvmsg
branch
from
August 23, 2023 22:06
ad201cc
to
26f02f0
Compare
maddeleine
approved these changes
Aug 24, 2023
lrstewart
reviewed
Aug 24, 2023
lrstewart
approved these changes
Aug 24, 2023
toidiu
force-pushed
the
ak-ktls1_recvmsg
branch
from
August 25, 2023 02:23
d7728c2
to
da5d88b
Compare
toidiu
force-pushed
the
ak-ktls1_recvmsg
branch
from
August 25, 2023 02:51
da5d88b
to
7895e12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds an implementation for s2n_ktls_recvmsg.
The function is responsible for calling
recvmsg
and retrieving some plaintext data from the socket (remember kTLS is responsible for performing the decryption). It also retrieves the record_type via control data from the socket by calling thes2n_get_control_data
fn which was added a couple of kTLS PRs ago.With this we have a basis for sending (sendmsg) and receiving (recvmsg) data when using kTLS. After this we will start integrating with the existing s2n-tls s2n_send and s2n_recv functions.
Call-outs:
Testing:
Unit tests
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.