remove kTLS feature probe #4064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
kTLS must rely on glibc on the host in order to retrieve headers since linux doesnt expose kTLS headers in its uapi. For this reason its not possible to detect kTLS feature support at compile time.
We currently import headers via glibc
#include <netinet/tcp.h>, but this breaks on hosts where the glibc version is too old.. aka AL2: #3949.Instead we will gate kTLS on
linuxand include kTLS headers inline, with the somewhat safe assumption that they remain stable in Linux.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.