Fixes pthread leak #4037
Merged
Fixes pthread leak #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrstewart
reviewed
Jun 7, 2023
lrstewart
reviewed
Jun 8, 2023
lrstewart
approved these changes
Jun 8, 2023
dougch
approved these changes
Jun 12, 2023
camshaft
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
resolves #3990
resolves #4042
Description of changes:
This change fixes the remaining pthread keys issue. We don't properly clean up our pthread key, which wouldn't matter if users don't call s2n_init more than once per process. However, in the case where you're creating threads inside of a loop and calling s2n_init in each thread, you will keep creating pthread keys and never cleaning them up and sooner or later you hit the pthread key limit.
I also added an explanation for how our auto-cleanup stuff works. Possibly we should rewrite this code so it isn't so confusing, but for now, this will help me remember how this stuff works the next time I have to touch it.
Call-outs:
Had to use a global variable to capture the output of pthread_key_create. Not exactly sure how to feel about that.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.