Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow running multiple integ tests at once in nix devshell #4029

Merged
merged 3 commits into from
Jun 9, 2023

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Jun 1, 2023

Resolved issues:

none

Description of changes:

For the integration tests in CI, we're currently passing a space delimited list of tests to TOX_TEST_NAME, so we can divide up the tests into groups to reduce the number of batch jobs while still using batch-matix.

Current grouping:

          INTEGV2_TEST:
            - "test_happy_path"
            - "test_cross_compatibility test_client_authentication"
            - "test_early_data test_sslyze test_well_known_endpoints test_hello_retry_requests test_sni_match test_pq_handshake test_fragmentation test_key_update"
            - "test_session_resumption test_renegotiate_apache test_buffered_send"
            - "test_dynamic_record_sizes test_npn test_signature_algorithms"
            - "test_version_negotiation test_external_psk test_ocsp test_renegotiate"

We'd like to continue using this pattern with nix, so this PR allows for passing a list of test names...

example:

nix develop .
clean;configure;build
integ happy_path client_authentication

Call-outs:

We're launching too many child jobs with the current vanilla build-matrix setup, we should expect to start seeing throttling.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

Is this a refactor change? If so, how have you proved that the intended behavior hasn't changed?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Jun 1, 2023
@dougch dougch marked this pull request as ready for review June 2, 2023 16:18
@dougch dougch requested review from goatgoose and toidiu June 2, 2023 16:19
@dougch dougch force-pushed the nix_multipleinteg branch from dbec400 to 3a427f5 Compare June 2, 2023 21:58
nix/shell.sh Outdated Show resolved Hide resolved
Co-authored-by: Sam Clark <[email protected]>
@dougch dougch requested a review from goatgoose June 5, 2023 23:47
@dougch dougch requested a review from aditishri18 June 7, 2023 23:03
@dougch dougch enabled auto-merge (squash) June 9, 2023 16:16
@dougch dougch merged commit 93754d9 into aws:main Jun 9, 2023
dougch added a commit to dougch/s2n-tls that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants