style: simplfy api for test utility #4008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WesleyRosenblum
approved these changes
May 16, 2023
toidiu
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current test pair API requires a parameter dictating the number of iterations (which I'm assuming is roughly the number of "polls" each peer gets) but we always use the same paramter. The general end consumer behavior is "enough iterations to make the handshake complete successfully", so the test constant of 100 was starting to proliferate across different files. We should make this the default.
Call-outs:
I originally just rolled this into a separate PR but it was making the other PR hard to read so separating this out.
Testing:
All CI should pass.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.