Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Bump nix devShell python to 3.10 #3914

Merged
merged 2 commits into from
Apr 6, 2023
Merged

test: Bump nix devShell python to 3.10 #3914

merged 2 commits into from
Apr 6, 2023

Conversation

dougch
Copy link
Contributor

@dougch dougch commented Mar 30, 2023

Resolved issues:

partial #3841

Description of changes:

Bump python version in nix devShell to python 3.10. Python3.9 is marked broken on arm.

Call-outs:

Current make/tox setup is to use python3.9, upgrading requires a CodeBuild Docker image rebuild.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? locally and in CI

Is this a refactor change? no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions github-actions bot added the s2n-core team label Mar 30, 2023
@dougch dougch requested a review from harrisonkaiser March 31, 2023 23:11
@dougch dougch marked this pull request as ready for review March 31, 2023 23:11
Copy link
Contributor

@harrisonkaiser harrisonkaiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dougch dougch requested a review from aditishri18 April 5, 2023 21:52
@dougch dougch added the type/nix related to nix label Apr 5, 2023
@dougch dougch merged commit 818a092 into aws:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s2n-core team type/nix related to nix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants