fix(dc): support updated wireshark definitions #2346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/dc-wireshark-update
branch
from
2eb0b6d
to
bdaf6d2
Compare
camshaft
force-pushed
the
camshaft/dc-wireshark-update
branch
5 times, most recently
from
89be741
to
96e8a4e
Compare
camshaft
force-pushed
the
camshaft/dc-wireshark-update
branch
from
96e8a4e
to
e91cdaa
Compare
WesleyRosenblum
approved these changes
Oct 9, 2024
|
Yeah probably worth a revisit. At least we're all green at this point 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change makes the dc wireshark plugin compatible with wireshark 4.4. Previously it only worked with 4.2.
Testing:
The tests are now passing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.