feat(s2n-quic-qns): add option to set max mtu #1782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
commented
May 31, 2023
| @@ -289,7 +289,7 @@ pub struct Counters { | |||
|
|
|||
| impl Counters { | |||
| pub fn print_header(&self) { | |||
| eprintln!( | |||
| println!( | |||
There was a problem hiding this comment.
Doing a println instead of a eprintln makes it easier to pipe the output to a tsv file for later use
Comment on lines
-35
to
-36
| S2N_UNSTABLE_CRYPTO_OPT_TX=1 \ | ||
| S2N_UNSTABLE_CRYPTO_OPT_RX=1 \ |
There was a problem hiding this comment.
It's probably best to be testing using what is in main rather than experimental features
| @@ -12,7 +12,9 @@ case "$PS" in | |||
| ../../target/release/s2n-quic-qns \ | |||
| perf \ | |||
| server \ | |||
| --port $SERVER_PORT | |||
| --port $SERVER_PORT \ | |||
| --max-mtu 16000 \ | |||
There was a problem hiding this comment.
It's over localhost, which technically supports 64k MTUs. But after playing around with some values it produced the best perf overall.
WesleyRosenblum
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When using the
perfserver and client it's nice to have a CLI argument to set the max MTU to see how that affects performance. I've also added the ability to swap tokio runtimes via CLI argument as well.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.