refactor(s2n-quic-platform): simplify Message trait #1778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/message-refactor
branch
from
fd84eff to
7dcd49f
Compare
camshaft
force-pushed
the
camshaft/message-refactor
branch
from
7dcd49f to
ebe4a58
Compare
toidiu
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The current
Messagetrait ins2n-quic-platformis showing a bit of cruft and has many functions that aren't used anymore. This PR removes them and simplifies the trait quite a bit.Call-outs:
Any functions that are only used for internal purposes (e.g. reading/writing ECN) have been moved to extension traits instead, which makes it so any message-specific complexity is isolated to that particular message.
Testing:
All of the existing tests should be sufficient to catch any regressions in the refactor.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.