refactor(s2n-quic-platform): move more syscalls to syscall module #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/more-syscalls
branch
5 times, most recently
from
b42d570
to
9e45908
Compare
camshaft
force-pushed
the
camshaft/more-syscalls
branch
from
9e45908
to
5e2e601
Compare
camshaft
changed the title
WesleyRosenblum
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Currently, the msg/mmsg syscalls require a particular not-so-flexible interface to be implemented to interact with them. This PR moves the actual syscall to a simple function to make it easier to use in more contexts.
This is needed to separate the endpoint task from the IO operations.
Call-outs:
I've added a few changes to add GRO support in the syscalls while I was here to minimize the merge conflicts.
I also have not refactored the old syscalls to use the new functions, as that implementation will be deleted in a later PR.
Testing:
There's not really a great way to test the syscalls on their own, however tests are coming in a later PR that tests them in context of the tokio IO provider.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.