ci: fix release workflow #1763
Merged
ci: fix release workflow #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/release-fix
branch
from
3220e07
to
4108e94
Compare
Comment on lines
-11
to
-12
| paths: | ||
| - ".github/workflows/release.yml" |
There was a problem hiding this comment.
Isn't this going to be pushing a new image on every PR now? Or is the push: ${{ github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/') }} on line 56 preventing that?
There was a problem hiding this comment.
yeah that should be only true when it's pushing to main.
WesleyRosenblum
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
In #1749, we added the s2n-quic-xdp crate as an optional dependency to
s2n-quic. This caused issues for the release workflow since thetools/xdpdirectory wasn't being added to the docker build.Testing:
I've enabled the workflow to run on pull requests to prevent this kind of issue in the future.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.