feat(s2n-quic-xdp): implement IO traits for vectors of channel pairs #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camshaft
force-pushed
the
camshaft/xdp-vec-io
branch
from
42d1617
to
e82c7d6
Compare
WesleyRosenblum
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
While integrating the AF_XDP IO provider into the qns application, I needed to have a channel per NIC queue on the TX and RX paths. This drove a refactor of the IO trait impls to handle a vector of channel pairs, rather than a single pair.
Call-outs:
With a single pair of channels, the behavior should be the exact same.
Testing:
I've updated the tests to also check for more than one pair of channels.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.